Commit c961a735 by Sam Padgett Committed by GitHub

Merge pull request #184 from spadgett/bind-application-runtime-error

Fix runtime error binding to app
parents 4bcf671a 594d5c6f
...@@ -1131,6 +1131,7 @@ angular.module("openshiftCommonServices") ...@@ -1131,6 +1131,7 @@ angular.module("openshiftCommonServices")
var parametersSecretName; var parametersSecretName;
var instanceName = serviceInstance.metadata.name; var instanceName = serviceInstance.metadata.name;
var credentialSecretName = generateSecretName(serviceInstance.metadata.name + '-credentials-');
var binding = { var binding = {
kind: 'Binding', kind: 'Binding',
apiVersion: 'servicecatalog.k8s.io/v1alpha1', apiVersion: 'servicecatalog.k8s.io/v1alpha1',
...@@ -1141,7 +1142,7 @@ angular.module("openshiftCommonServices") ...@@ -1141,7 +1142,7 @@ angular.module("openshiftCommonServices")
instanceRef: { instanceRef: {
name: instanceName name: instanceName
}, },
secretName: generateSecretName(serviceInstance.metadata.name + '-credentials-') secretName: credentialSecretName
} }
}; };
...@@ -1163,7 +1164,7 @@ angular.module("openshiftCommonServices") ...@@ -1163,7 +1164,7 @@ angular.module("openshiftCommonServices")
}; };
} }
binding.spec.alphaPodPresetTemplate = { binding.spec.alphaPodPresetTemplate = {
name: relatedObjName, name: credentialSecretName,
selector: appSelector selector: appSelector
}; };
} }
......
...@@ -3011,6 +3011,7 @@ angular.module("openshiftCommonServices") ...@@ -3011,6 +3011,7 @@ angular.module("openshiftCommonServices")
var parametersSecretName; var parametersSecretName;
var instanceName = serviceInstance.metadata.name; var instanceName = serviceInstance.metadata.name;
var credentialSecretName = generateSecretName(serviceInstance.metadata.name + '-credentials-');
var binding = { var binding = {
kind: 'Binding', kind: 'Binding',
apiVersion: 'servicecatalog.k8s.io/v1alpha1', apiVersion: 'servicecatalog.k8s.io/v1alpha1',
...@@ -3021,7 +3022,7 @@ angular.module("openshiftCommonServices") ...@@ -3021,7 +3022,7 @@ angular.module("openshiftCommonServices")
instanceRef: { instanceRef: {
name: instanceName name: instanceName
}, },
secretName: generateSecretName(serviceInstance.metadata.name + '-credentials-') secretName: credentialSecretName
} }
}; };
...@@ -3043,7 +3044,7 @@ angular.module("openshiftCommonServices") ...@@ -3043,7 +3044,7 @@ angular.module("openshiftCommonServices")
}; };
} }
binding.spec.alphaPodPresetTemplate = { binding.spec.alphaPodPresetTemplate = {
name: relatedObjName, name: credentialSecretName,
selector: appSelector selector: appSelector
}; };
} }
......
...@@ -1217,7 +1217,7 @@ stringData:{} ...@@ -1217,7 +1217,7 @@ stringData:{}
}; };
return secret.stringData[PARAMETERS_SECRET_KEY] = JSON.stringify(parameters), secret; return secret.stringData[PARAMETERS_SECRET_KEY] = JSON.stringify(parameters), secret;
}, makeBinding = function(serviceInstance, application, parametersSecretName) { }, makeBinding = function(serviceInstance, application, parametersSecretName) {
var parametersSecretName, instanceName = serviceInstance.metadata.name, binding = { var parametersSecretName, instanceName = serviceInstance.metadata.name, credentialSecretName = generateSecretName(serviceInstance.metadata.name + "-credentials-"), binding = {
kind:"Binding", kind:"Binding",
apiVersion:"servicecatalog.k8s.io/v1alpha1", apiVersion:"servicecatalog.k8s.io/v1alpha1",
metadata:{ metadata:{
...@@ -1227,7 +1227,7 @@ spec:{ ...@@ -1227,7 +1227,7 @@ spec:{
instanceRef:{ instanceRef:{
name:instanceName name:instanceName
}, },
secretName:generateSecretName(serviceInstance.metadata.name + "-credentials-") secretName:credentialSecretName
} }
}; };
parametersSecretName && (binding.spec.parametersFrom = [ { parametersSecretName && (binding.spec.parametersFrom = [ {
...@@ -1240,7 +1240,7 @@ var appSelector = _.get(application, "spec.selector"); ...@@ -1240,7 +1240,7 @@ var appSelector = _.get(application, "spec.selector");
return appSelector && (appSelector.matchLabels || appSelector.matchExpressions || (appSelector = { return appSelector && (appSelector.matchLabels || appSelector.matchExpressions || (appSelector = {
matchLabels:appSelector matchLabels:appSelector
}), binding.spec.alphaPodPresetTemplate = { }), binding.spec.alphaPodPresetTemplate = {
name:relatedObjName, name:credentialSecretName,
selector:appSelector selector:appSelector
}), binding; }), binding;
}, isServiceBindable = function(serviceInstance, serviceClasses) { }, isServiceBindable = function(serviceInstance, serviceClasses) {
......
...@@ -68,6 +68,7 @@ angular.module("openshiftCommonServices") ...@@ -68,6 +68,7 @@ angular.module("openshiftCommonServices")
var parametersSecretName; var parametersSecretName;
var instanceName = serviceInstance.metadata.name; var instanceName = serviceInstance.metadata.name;
var credentialSecretName = generateSecretName(serviceInstance.metadata.name + '-credentials-');
var binding = { var binding = {
kind: 'Binding', kind: 'Binding',
apiVersion: 'servicecatalog.k8s.io/v1alpha1', apiVersion: 'servicecatalog.k8s.io/v1alpha1',
...@@ -78,7 +79,7 @@ angular.module("openshiftCommonServices") ...@@ -78,7 +79,7 @@ angular.module("openshiftCommonServices")
instanceRef: { instanceRef: {
name: instanceName name: instanceName
}, },
secretName: generateSecretName(serviceInstance.metadata.name + '-credentials-') secretName: credentialSecretName
} }
}; };
...@@ -100,7 +101,7 @@ angular.module("openshiftCommonServices") ...@@ -100,7 +101,7 @@ angular.module("openshiftCommonServices")
}; };
} }
binding.spec.alphaPodPresetTemplate = { binding.spec.alphaPodPresetTemplate = {
name: relatedObjName, name: credentialSecretName,
selector: appSelector selector: appSelector
}; };
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment