Commit b6fc2bef by David Taylor Committed by GitHub

Merge pull request #104 from spadgett/remove-deprecated-alert-message-service-methods

[WIP] Remove unused AlertMessageService methods
parents 71d92355 dc67a27d
...@@ -173,7 +173,6 @@ hawtioPluginLoader.registerPreBootstrapTask(function(next) { ...@@ -173,7 +173,6 @@ hawtioPluginLoader.registerPreBootstrapTask(function(next) {
angular.module("openshiftCommonServices") angular.module("openshiftCommonServices")
.service("AlertMessageService", function(){ .service("AlertMessageService", function(){
var alerts = [];
var alertHiddenKey = function(alertID, namespace) { var alertHiddenKey = function(alertID, namespace) {
if (!namespace) { if (!namespace) {
return 'hide/alert/' + alertID; return 'hide/alert/' + alertID;
...@@ -182,15 +181,6 @@ angular.module("openshiftCommonServices") ...@@ -182,15 +181,6 @@ angular.module("openshiftCommonServices")
return 'hide/alert/' + namespace + '/' + alertID; return 'hide/alert/' + namespace + '/' + alertID;
}; };
return { return {
addAlert: function(alert) {
alerts.push(alert);
},
getAlerts: function() {
return alerts;
},
clearAlerts: function() {
alerts = [];
},
isAlertPermanentlyHidden: function(alertID, namespace) { isAlertPermanentlyHidden: function(alertID, namespace) {
var key = alertHiddenKey(alertID, namespace); var key = alertHiddenKey(alertID, namespace);
return localStorage.getItem(key) === 'true'; return localStorage.getItem(key) === 'true';
......
...@@ -1807,7 +1807,6 @@ angular.module('openshiftCommonUI') ...@@ -1807,7 +1807,6 @@ angular.module('openshiftCommonUI')
angular.module("openshiftCommonServices") angular.module("openshiftCommonServices")
.service("AlertMessageService", function(){ .service("AlertMessageService", function(){
var alerts = [];
var alertHiddenKey = function(alertID, namespace) { var alertHiddenKey = function(alertID, namespace) {
if (!namespace) { if (!namespace) {
return 'hide/alert/' + alertID; return 'hide/alert/' + alertID;
...@@ -1816,15 +1815,6 @@ angular.module("openshiftCommonServices") ...@@ -1816,15 +1815,6 @@ angular.module("openshiftCommonServices")
return 'hide/alert/' + namespace + '/' + alertID; return 'hide/alert/' + namespace + '/' + alertID;
}; };
return { return {
addAlert: function(alert) {
alerts.push(alert);
},
getAlerts: function() {
return alerts;
},
clearAlerts: function() {
alerts = [];
},
isAlertPermanentlyHidden: function(alertID, namespace) { isAlertPermanentlyHidden: function(alertID, namespace) {
var key = alertHiddenKey(alertID, namespace); var key = alertHiddenKey(alertID, namespace);
return localStorage.getItem(key) === 'true'; return localStorage.getItem(key) === 'true';
......
...@@ -702,19 +702,10 @@ var status = result.status || error.status; ...@@ -702,19 +702,10 @@ var status = result.status || error.status;
return status ? "Status: " + status :""; return status ? "Status: " + status :"";
}; };
} ]), angular.module("openshiftCommonServices").service("AlertMessageService", function() { } ]), angular.module("openshiftCommonServices").service("AlertMessageService", function() {
var alerts = [], alertHiddenKey = function(alertID, namespace) { var alertHiddenKey = function(alertID, namespace) {
return namespace ? "hide/alert/" + namespace + "/" + alertID :"hide/alert/" + alertID; return namespace ? "hide/alert/" + namespace + "/" + alertID :"hide/alert/" + alertID;
}; };
return { return {
addAlert:function(alert) {
alerts.push(alert);
},
getAlerts:function() {
return alerts;
},
clearAlerts:function() {
alerts = [];
},
isAlertPermanentlyHidden:function(alertID, namespace) { isAlertPermanentlyHidden:function(alertID, namespace) {
var key = alertHiddenKey(alertID, namespace); var key = alertHiddenKey(alertID, namespace);
return "true" === localStorage.getItem(key); return "true" === localStorage.getItem(key);
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
angular.module("openshiftCommonServices") angular.module("openshiftCommonServices")
.service("AlertMessageService", function(){ .service("AlertMessageService", function(){
var alerts = [];
var alertHiddenKey = function(alertID, namespace) { var alertHiddenKey = function(alertID, namespace) {
if (!namespace) { if (!namespace) {
return 'hide/alert/' + alertID; return 'hide/alert/' + alertID;
...@@ -11,15 +10,6 @@ angular.module("openshiftCommonServices") ...@@ -11,15 +10,6 @@ angular.module("openshiftCommonServices")
return 'hide/alert/' + namespace + '/' + alertID; return 'hide/alert/' + namespace + '/' + alertID;
}; };
return { return {
addAlert: function(alert) {
alerts.push(alert);
},
getAlerts: function() {
return alerts;
},
clearAlerts: function() {
alerts = [];
},
isAlertPermanentlyHidden: function(alertID, namespace) { isAlertPermanentlyHidden: function(alertID, namespace) {
var key = alertHiddenKey(alertID, namespace); var key = alertHiddenKey(alertID, namespace);
return localStorage.getItem(key) === 'true'; return localStorage.getItem(key) === 'true';
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment