Bug 1493439 - Remove the canI check for secrets from bind-result

The `canI` check only works if you've visited the project. This is not
always true when provisioning from the catalog, so it means the secret
is sometimes not displayed as a link when it should be.

To provision a service or create a binding with parameters, it's
required that the user create secrets anyway, so the check should never
fail is permissions are set up properly.

If the user doesn't have authority, the worst that happens is that they
see a permission denied error following the link. In practice, it
shouldn't happen.

https://bugzilla.redhat.com/show_bug.cgi?id=1493439

dist/origin-web-common-ui.js

@@ -111,9 +111,8 @@ hawtioPluginLoader.addModule('openshiftCommonUI');
     "    </div>\n" +
     "    <div class=\"sub-title\">\n" +
     "      The binding operation created the secret\n" +
-    "      <a ng-if=\"ctrl.secretHref && 'secrets' | canI : 'list'\"\n" +
-    "         ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
-    "      <span ng-if=\"!ctrl.secretHref || !('secrets' | canI : 'list')\">{{ctrl.binding.spec.secretName}}</span>\n" +
+    "      <a ng-if=\"ctrl.secretHref\" ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
+    "      <span ng-if=\"!ctrl.secretHref\">{{ctrl.binding.spec.secretName}}</span>\n" +
     "      that you may need to reference in your application.\n" +
     "      <span ng-if=\"ctrl.showPodPresets\">Its data will be available to your application as environment variables.</span>\n" +
     "    </div>\n" +

dist/origin-web-common.js

@@ -282,9 +282,8 @@ hawtioPluginLoader.addModule('openshiftCommonUI');
     "    </div>\n" +
     "    <div class=\"sub-title\">\n" +
     "      The binding operation created the secret\n" +
-    "      <a ng-if=\"ctrl.secretHref && 'secrets' | canI : 'list'\"\n" +
-    "         ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
-    "      <span ng-if=\"!ctrl.secretHref || !('secrets' | canI : 'list')\">{{ctrl.binding.spec.secretName}}</span>\n" +
+    "      <a ng-if=\"ctrl.secretHref\" ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
+    "      <span ng-if=\"!ctrl.secretHref\">{{ctrl.binding.spec.secretName}}</span>\n" +
     "      that you may need to reference in your application.\n" +
     "      <span ng-if=\"ctrl.showPodPresets\">Its data will be available to your application as environment variables.</span>\n" +
     "    </div>\n" +

dist/scripts/templates.js

@@ -82,9 +82,8 @@ angular.module('openshiftCommonUI').run(['$templateCache', function($templateCac
     "    </div>\n" +
     "    <div class=\"sub-title\">\n" +
     "      The binding operation created the secret\n" +
-    "      <a ng-if=\"ctrl.secretHref && 'secrets' | canI : 'list'\"\n" +
-    "         ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
-    "      <span ng-if=\"!ctrl.secretHref || !('secrets' | canI : 'list')\">{{ctrl.binding.spec.secretName}}</span>\n" +
+    "      <a ng-if=\"ctrl.secretHref\" ng-href=\"{{ctrl.secretHref}}\">{{ctrl.binding.spec.secretName}}</a>\n" +
+    "      <span ng-if=\"!ctrl.secretHref\">{{ctrl.binding.spec.secretName}}</span>\n" +
     "      that you may need to reference in your application.\n" +
     "      <span ng-if=\"ctrl.showPodPresets\">Its data will be available to your application as environment variables.</span>\n" +
     "    </div>\n" +

src/components/binding/bindResults.html

@@ -18,9 +18,8 @@
     </div>
     <div class="sub-title">
       The binding operation created the secret
-      <a ng-if="ctrl.secretHref && 'secrets' | canI : 'list'"
-         ng-href="{{ctrl.secretHref}}">{{ctrl.binding.spec.secretName}}</a>
-      <span ng-if="!ctrl.secretHref || !('secrets' | canI : 'list')">{{ctrl.binding.spec.secretName}}</span>
+      <a ng-if="ctrl.secretHref" ng-href="{{ctrl.secretHref}}">{{ctrl.binding.spec.secretName}}</a>
+      <span ng-if="!ctrl.secretHref">{{ctrl.binding.spec.secretName}}</span>
       that you may need to reference in your application.
       <span ng-if="ctrl.showPodPresets">Its data will be available to your application as environment variables.</span>
     </div>