Commit 18c1a185 by Samuel Padgett

Only show "Name is required" if input $dirty

Use `$dirty` instead of `$touched` before showing the name required
message. This prevents a bug where the Cancel button moves in the create
dialog when clicked. The name required message appears, causing the
button to move mid-click, and the dialog isn't dismissed.
parent 485fd0f3
......@@ -39,7 +39,7 @@ hawtioPluginLoader.addModule('openshiftCommonUI');
" <span class=\"help-block\">A unique name for the project.</span>\n" +
" </div>\n" +
" <div class=\"has-error\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$touched\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$dirty\">\n" +
" Name is required.\n" +
" </span>\n" +
" </div>\n" +
......
......@@ -209,7 +209,7 @@ hawtioPluginLoader.addModule('openshiftCommonUI');
" <span class=\"help-block\">A unique name for the project.</span>\n" +
" </div>\n" +
" <div class=\"has-error\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$touched\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$dirty\">\n" +
" Name is required.\n" +
" </span>\n" +
" </div>\n" +
......
This source diff could not be displayed because it is too large. You can view the blob instead.
......@@ -29,7 +29,7 @@ angular.module('openshiftCommonUI').run(['$templateCache', function($templateCac
" <span class=\"help-block\">A unique name for the project.</span>\n" +
" </div>\n" +
" <div class=\"has-error\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$touched\">\n" +
" <span id=\"nameHelp\" class=\"help-block\" ng-if=\"createProjectForm.name.$error.required && createProjectForm.name.$dirty\">\n" +
" Name is required.\n" +
" </span>\n" +
" </div>\n" +
......
......@@ -25,7 +25,7 @@
<span class="help-block">A unique name for the project.</span>
</div>
<div class="has-error">
<span id="nameHelp" class="help-block" ng-if="createProjectForm.name.$error.required && createProjectForm.name.$touched">
<span id="nameHelp" class="help-block" ng-if="createProjectForm.name.$error.required && createProjectForm.name.$dirty">
Name is required.
</span>
</div>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment